#3 change sessions impl

stbf-api/src/main/java/ru/penkrat/stbf/api/BotRequest.java

@@ -14,4 +14,5 @@ public interface BotRequest {
 
 	Long getChatId();
 
+	BotSession getSession();
 }

stbf-api/src/main/java/ru/penkrat/stbf/api/BotSession.java

@@ -0,0 +1,9 @@
+package ru.penkrat.stbf.api;
+
+public interface BotSession {
+
+    Object getAttribute(String name);
+
+    void setAttribute(String name, Object value);
+
+}

stbf-api/src/main/java/ru/penkrat/stbf/api/SessionProvider.java

@@ -0,0 +1,8 @@
+package ru.penkrat.stbf.api;
+
+@FunctionalInterface
+public interface SessionProvider {
+
+    BotSession get(Long chatId);
+
+}

stbf-common/src/main/java/ru/penkrat/stbf/common/command/SessionAwareCommandChain.java

@@ -0,0 +1,20 @@
+package ru.penkrat.stbf.common.command;
+
+import lombok.RequiredArgsConstructor;
+import ru.penkrat.stbf.api.BotRequest;
+import ru.penkrat.stbf.api.BotResponse;
+import ru.penkrat.stbf.api.CommandChain;
+import ru.penkrat.stbf.api.SessionProvider;
+import ru.penkrat.stbf.common.session.SessionAwareBotRequest;
+
+@RequiredArgsConstructor
+public class SessionAwareCommandChain implements CommandChain {
+
+	private final CommandChain delegate;
+	private final SessionProvider sessionProvider;
+
+	@Override
+	public void processCommand(BotRequest botRequest, BotResponse botResponse) {
+		delegate.processCommand(new SessionAwareBotRequest(botRequest, sessionProvider), botResponse);
+	}
+}

stbf-common/src/main/java/ru/penkrat/stbf/common/command/ThreadPolledCommandChain.java

@@ -0,0 +1,31 @@
+package ru.penkrat.stbf.common.command;
+
+import ru.penkrat.stbf.api.BotRequest;
+import ru.penkrat.stbf.api.BotResponse;
+import ru.penkrat.stbf.api.CommandChain;
+
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+
+public class ThreadPolledCommandChain implements CommandChain {
+
+	private final CommandChain delegate;
+	private final ExecutorService executor;
+
+	public ThreadPolledCommandChain(CommandChain delegate) {
+		this(delegate, 4);
+	}
+
+	public ThreadPolledCommandChain(CommandChain delegate, int nThreads) {
+		this.delegate = delegate;
+		this.executor = Executors.newFixedThreadPool(nThreads);
+	}
+
+	@Override
+	public void processCommand(BotRequest botRequest, BotResponse botResponse) {
+		executor.execute(() -> {
+			delegate.processCommand(botRequest, botResponse);
+		});
+	}
+
+}

stbf-common/src/main/java/ru/penkrat/stbf/common/session/InMemBotSessionProvider.java

@@ -0,0 +1,18 @@
+package ru.penkrat.stbf.common.session;
+
+import ru.penkrat.stbf.api.BotSession;
+import ru.penkrat.stbf.api.SessionProvider;
+
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+
+public class InMemBotSessionProvider implements SessionProvider {
+
+    private static final Map<Long, BotSession> MAP = new ConcurrentHashMap<>();
+
+    @Override
+    public BotSession get(Long chatId) {
+        return MAP.computeIfAbsent(chatId, k -> new MapBackedBotSession(new ConcurrentHashMap<>()));
+    }
+
+}

stbf-common/src/main/java/ru/penkrat/stbf/common/session/MapBackedBotSession.java

@@ -0,0 +1,22 @@
+package ru.penkrat.stbf.common.session;
+
+import lombok.RequiredArgsConstructor;
+import ru.penkrat.stbf.api.BotSession;
+
+import java.util.Map;
+
+@RequiredArgsConstructor
+class MapBackedBotSession implements BotSession {
+
+    private final Map<String, Object> map;
+
+    @Override
+    public Object getAttribute(String name) {
+        return map.get(name);
+    }
+
+    @Override
+    public void setAttribute(String name, Object value) {
+        map.put(name, value);
+    }
+}

stbf-common/src/main/java/ru/penkrat/stbf/common/session/SessionAwareBotRequest.java

@@ -0,0 +1,49 @@
+package ru.penkrat.stbf.common.session;
+
+import lombok.RequiredArgsConstructor;
+import ru.penkrat.stbf.api.BotRequest;
+import ru.penkrat.stbf.api.BotSession;
+import ru.penkrat.stbf.api.SessionProvider;
+
+import java.util.Objects;
+import java.util.Optional;
+
+@RequiredArgsConstructor
+public class SessionAwareBotRequest implements BotRequest {
+
+	private final BotRequest delegate;
+
+	private final SessionProvider sessionProvider;
+
+	private BotSession botSession;
+
+	@Override
+	public BotSession getSession() {
+		if (botSession == null) {
+			botSession = sessionProvider.get(getChatId());
+			Objects.requireNonNull(botSession, "Session can not be null");
+		}
+		return botSession;
+	}
+
+	public Optional<String> getMessageText() {
+		return this.delegate.getMessageText();
+	}
+
+	public Optional<String> getPhoneNumber() {
+		return this.delegate.getPhoneNumber();
+	}
+
+	public Optional<String> getCallbackData() {
+		return this.delegate.getCallbackData();
+	}
+
+	public Optional<String> getCallbackMessageText() {
+		return this.delegate.getCallbackMessageText();
+	}
+
+	public Long getChatId() {
+		return this.delegate.getChatId();
+	}
+
+}

stbf-demo/pom.xml

@@ -34,6 +34,11 @@
             <groupId>ru.penkrat.stbf</groupId>
             <version>${project.version}</version>
         </dependency>
+        <dependency>
+            <artifactId>stbf-common</artifactId>
+            <groupId>ru.penkrat.stbf</groupId>
+            <version>${project.version}</version>
+        </dependency>
         <dependency>
             <groupId>info.picocli</groupId>
             <artifactId>picocli</artifactId>

stbf-demo/src/main/java/ru/penkrat/stbf/demo/App.java

@@ -5,64 +5,67 @@ import org.slf4j.LoggerFactory;
 import picocli.CommandLine;
 import ru.penkrat.stbf.api.BotCommandChain;
 import ru.penkrat.stbf.api.CommandChain;
+import ru.penkrat.stbf.common.command.SessionAwareCommandChain;
+import ru.penkrat.stbf.common.command.ThreadPolledCommandChain;
+import ru.penkrat.stbf.common.session.InMemBotSessionProvider;
 import ru.penkrat.stbf.impl.pengrad.PengradTelegramBot;
 import ru.penkrat.stbf.templates.xml.XmlFlowResolver;
 
 import java.util.concurrent.atomic.AtomicReference;
 
 @CommandLine.Command(name = "java -jar stbf-demo.jar", mixinStandardHelpOptions = true, description = "Run bot",
-        version = "Simple Telegram bot framework Demo app v. 0.0.1")
+		version = "Simple Telegram bot framework Demo app v. 0.0.2")
 public class App implements Runnable {
 
-    private static final Logger log = LoggerFactory.getLogger(App.class);
+	private static final Logger log = LoggerFactory.getLogger(App.class);
 
-    private static AtomicReference<PengradTelegramBot> botAtomicReference = new AtomicReference<>();
+	private static AtomicReference<PengradTelegramBot> botAtomicReference = new AtomicReference<>();
 
-    @CommandLine.Option(names = {"-f", "--file"}, description = "The file with config.")
+	@CommandLine.Option(names = {"-f", "--file"}, description = "The file with config.")
-    private String flowFile = "classpath:/flow.xml";
+	private String flowFile = "classpath:/flow.xml";
 
-    @CommandLine.Option(names = {"-t", "--token"}, required = true, description = "bot token 1234:abscdf...")
+	@CommandLine.Option(names = {"-t", "--token"}, required = true, description = "bot token 1234:abscdf...")
-    private String botToken = "";
+	private String botToken = "";
 
-    public static void main(String[] args) {
+	public static void main(String[] args) {
-        new CommandLine(new App()).execute(args);
+		new CommandLine(new App()).execute(args);
-    }
+	}
 
-    private BotCommandChain getCommandChain(String filename) {
+	private CommandChain getCommandChain(String filename) {
-        XmlFlowResolver flow = new XmlFlowResolver(filename);
+		XmlFlowResolver flow = new XmlFlowResolver(filename);
 
-        BotCommandChain chain = new BotCommandChain();
+		BotCommandChain chain = new BotCommandChain();
-        flow.getCommands().forEach(chain::add);
+		flow.getCommands().forEach(chain::add);
 
-        return chain;
+		return new ThreadPolledCommandChain(new SessionAwareCommandChain(chain, new InMemBotSessionProvider()));
-    }
+	}
 
-    private Runnable start(String token, CommandChain chain) {
+	private Runnable start(String token, CommandChain chain) {
-        return () -> botAtomicReference.set(new PengradTelegramBot(token, chain));
+		return () -> botAtomicReference.set(new PengradTelegramBot(token, chain));
-    }
+	}
 
-    private void onShutdown() {
+	private void onShutdown() {
-        try {
+		try {
-            if (botAtomicReference.get() != null) {
+			if (botAtomicReference.get() != null) {
-                botAtomicReference.get().close();
+				botAtomicReference.get().close();
-                log.info("Bot finished.");
+				log.info("Bot finished.");
-            }
+			}
-        } catch (Exception e) {
+		} catch (Exception e) {
-            log.error("Error:", e);
+			log.error("Error:", e);
-        }
+		}
-    }
+	}
 
-    @Override
+	@Override
-    public void run() {
+	public void run() {
-        Thread botThread = new Thread(start(botToken, getCommandChain(flowFile)));
+		Thread botThread = new Thread(start(botToken, getCommandChain(flowFile)));
-        botThread.setDaemon(false);
+		botThread.setDaemon(false);
-        botThread.setName("stbf-bot-thread");
+		botThread.setName("stbf-bot-thread");
 
-        Runtime.getRuntime().addShutdownHook(new Thread(this::onShutdown));
+		Runtime.getRuntime().addShutdownHook(new Thread(this::onShutdown));
 
-        log.info("Starting bot...");
+		log.info("Starting bot...");
-        botThread.start();
+		botThread.start();
-        log.info("Bot started.");
+		log.info("Bot started.");
-        log.info("Press Ctrl+C to exit.");
+		log.info("Press Ctrl+C to exit.");
-    }
+	}
 }

stbf-pengrad/pom.xml

@@ -21,7 +21,7 @@
 		<dependency>
 			<groupId>com.github.pengrad</groupId>
 			<artifactId>java-telegram-bot-api</artifactId>
-			<version>[4.9.0,5.2.0]</version>
+			<version>6.2.0</version>
 		</dependency>
 	</dependencies>
 

stbf-pengrad/src/main/java/ru/penkrat/stbf/impl/pengrad/BotRequestImpl.java

@@ -1,17 +1,17 @@
 package ru.penkrat.stbf.impl.pengrad;
 
-import static lombok.AccessLevel.PROTECTED;
-
-import java.util.Optional;
-
 import com.pengrad.telegrambot.model.CallbackQuery;
 import com.pengrad.telegrambot.model.Contact;
 import com.pengrad.telegrambot.model.Message;
 import com.pengrad.telegrambot.model.Update;
-
 import lombok.Getter;
 import lombok.RequiredArgsConstructor;
 import ru.penkrat.stbf.api.BotRequest;
+import ru.penkrat.stbf.api.BotSession;
+
+import java.util.Optional;
+
+import static lombok.AccessLevel.PROTECTED;
 
 @RequiredArgsConstructor
 public class BotRequestImpl implements BotRequest {
@@ -58,4 +58,9 @@ public class BotRequestImpl implements BotRequest {
 				.orElseGet(() -> update.message()).chat().id();
 	}
 
+	@Override
+	public BotSession getSession() {
+		throw new UnsupportedOperationException("Session is not supported");
+	}
+
 }

stbf-pengrad/src/main/java/ru/penkrat/stbf/impl/pengrad/BotResponseImpl.java

@@ -11,6 +11,7 @@ import com.pengrad.telegrambot.request.AbstractSendRequest;
 import com.pengrad.telegrambot.request.DeleteMessage;
 import com.pengrad.telegrambot.request.EditMessageText;
 import com.pengrad.telegrambot.request.SendDocument;
+import com.pengrad.telegrambot.response.BaseResponse;
 import com.pengrad.telegrambot.response.SendResponse;
 import lombok.RequiredArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
@@ -27,7 +28,7 @@ public class BotResponseImpl implements BotResponse {
 
     @Override
     public void send(Screen screen) {
-        log.debug("Send message: \n============\n{}\n============", screen.getText().trim());
+        log.trace("Send trace: \n============\n{}\n============", screen.getText().trim());
 
         AbstractSendRequest<? extends AbstractSendRequest> sendMessage = SendMethodUtils.createFromScreen(chatId(), screen);
 
@@ -36,8 +37,8 @@ public class BotResponseImpl implements BotResponse {
             KeyboardButton[][] keyboard = kk.getKeyboard();
             InlineKeyboardButton[][] inlineKeyboard = kk.getInlineKeyboard();
 
-            if (log.isDebugEnabled()) {
+            if (log.isTraceEnabled()) {
-                log.debug("{}", kk.toFriendlyString());
+                log.trace("{}", kk.toFriendlyString());
             }
 
             if (inlineKeyboard != null && inlineKeyboard.length > 0) {
@@ -45,12 +46,14 @@ public class BotResponseImpl implements BotResponse {
             } else if (keyboard != null && keyboard.length > 0) {
                 sendMessage = sendMessage.replyMarkup(new ReplyKeyboardMarkup(keyboard));
             } else {
-                log.debug("No keyboard");
+                log.trace("No keyboard");
             }
         }
 
         final SendResponse sendResponse = telegramBot.execute(sendMessage);
         SendMethodUtils.processResponse(screen, sendResponse);
+
+        log.debug("Response message = {}", sendResponse.message().messageId());
     }
 
     @Override
@@ -76,18 +79,23 @@ public class BotResponseImpl implements BotResponse {
             KeyboardImpl kk = (KeyboardImpl) screen.getKeyboard();
             InlineKeyboardButton[][] inlineKeyboard = kk.getInlineKeyboard();
 
-            if (log.isDebugEnabled()) {
+            if (log.isTraceEnabled()) {
-                log.debug("{}", kk.toFriendlyString());
+                log.trace("{}", kk.toFriendlyString());
             }
 
             if (inlineKeyboard != null && inlineKeyboard.length > 0) {
                 editMessage = editMessage.replyMarkup(new InlineKeyboardMarkup(inlineKeyboard));
             } else {
-                log.debug("No keyboard");
+                log.trace("No keyboard");
             }
         }
 
-        telegramBot.execute(editMessage);
+        final BaseResponse response = telegramBot.execute(editMessage);
+        if (response.isOk()) {
+            log.debug("Response ok, edit message = {}", messageId());
+        } else {
+            log.debug("Response error code {}", response.errorCode());
+        }
     }
 
     @Override

stbf-pengrad/src/main/java/ru/penkrat/stbf/impl/pengrad/KeyboardImpl.java

@@ -1,6 +1,6 @@
 package ru.penkrat.stbf.impl.pengrad;
 
-import com.google.gson.internal.reflect.ReflectionAccessor;
+import com.google.gson.internal.reflect.ReflectionHelper;
 import com.pengrad.telegrambot.model.request.InlineKeyboardButton;
 import com.pengrad.telegrambot.model.request.KeyboardButton;
 import lombok.Value;
@@ -58,7 +58,7 @@ class KeyboardImpl implements Keyboard {
         return text.computeIfAbsent(btn, o -> {
             try {
                 Field text = btn.getClass().getDeclaredField("text");
-                ReflectionAccessor.getInstance().makeAccessible(text);
+                ReflectionHelper.makeAccessible(text);
                 return String.valueOf(text.get(btn));
             } catch (NoSuchFieldException | IllegalAccessException e) {
                 return "*error*";

stbf-pengrad/src/main/java/ru/penkrat/stbf/impl/pengrad/PengradTelegramBot.java

@@ -2,11 +2,13 @@ package ru.penkrat.stbf.impl.pengrad;
 
 import com.pengrad.telegrambot.TelegramBot;
 import com.pengrad.telegrambot.UpdatesListener;
+import com.pengrad.telegrambot.model.CallbackQuery;
 import com.pengrad.telegrambot.model.Update;
-
 import lombok.extern.slf4j.Slf4j;
 import ru.penkrat.stbf.api.CommandChain;
 
+import java.util.Optional;
+
 @Slf4j
 public class PengradTelegramBot extends TelegramBot implements AutoCloseable {
 
@@ -15,6 +17,13 @@ public class PengradTelegramBot extends TelegramBot implements AutoCloseable {
 		this.setUpdatesListener(updates -> {
 			for (Update update : updates) {
 				try {
+					final Long chatId = Optional.of(update)
+							.map(Update::callbackQuery)
+							.map(CallbackQuery::message)
+							.orElseGet(() -> update.message()).chat().id();
+
+					log.debug("New message in chat {}", chatId);
+
 					commandChain.processCommand(
 							new BotRequestImpl(update),
 							new BotResponseImpl(update, this));

stbf-rubenlagus/src/main/java/ru/penkrat/stbf/impl/rubenlagus/BotRequestImpl.java

@@ -1,17 +1,17 @@
 package ru.penkrat.stbf.impl.rubenlagus;
 
-import static lombok.AccessLevel.PROTECTED;
+import lombok.Getter;
-
+import lombok.RequiredArgsConstructor;
-import java.util.Optional;
-
 import org.telegram.telegrambots.meta.api.objects.CallbackQuery;
 import org.telegram.telegrambots.meta.api.objects.Contact;
 import org.telegram.telegrambots.meta.api.objects.Message;
 import org.telegram.telegrambots.meta.api.objects.Update;
-
-import lombok.Getter;
-import lombok.RequiredArgsConstructor;
 import ru.penkrat.stbf.api.BotRequest;
+import ru.penkrat.stbf.api.BotSession;
+
+import java.util.Optional;
+
+import static lombok.AccessLevel.PROTECTED;
 
 @RequiredArgsConstructor
 class BotRequestImpl implements BotRequest {
@@ -52,7 +52,12 @@ class BotRequestImpl implements BotRequest {
 
 	@Override
 	public Long getChatId() {
-		return update.getMessage().getChatId();
+		return Utils.getChatId(update);
+	}
+
+	@Override
+	public BotSession getSession() {
+		throw new UnsupportedOperationException("Session is not supported");
 	}
 
 }

stbf-rubenlagus/src/main/java/ru/penkrat/stbf/impl/rubenlagus/RubenlagusTelegramBot.java

@@ -1,12 +1,11 @@
 package ru.penkrat.stbf.impl.rubenlagus;
 
+import lombok.extern.slf4j.Slf4j;
 import org.telegram.telegrambots.bots.TelegramLongPollingBot;
 import org.telegram.telegrambots.meta.TelegramBotsApi;
 import org.telegram.telegrambots.meta.api.objects.Update;
 import org.telegram.telegrambots.meta.exceptions.TelegramApiException;
 import org.telegram.telegrambots.updatesreceivers.DefaultBotSession;
-
-import lombok.extern.slf4j.Slf4j;
 import ru.penkrat.stbf.api.BotCommandChain;
 
 @Slf4j

stbf-rubenlagus/src/main/java/ru/penkrat/stbf/impl/rubenlagus/Utils.java

@@ -0,0 +1,21 @@
+package ru.penkrat.stbf.impl.rubenlagus;
+
+import lombok.experimental.UtilityClass;
+import org.telegram.telegrambots.meta.api.objects.Update;
+
+@UtilityClass
+class Utils {
+
+    Long getChatId(Update update) {
+        if (update.getMessage() != null) {
+            return update.getMessage().getChatId();
+        }
+
+        if (update.getCallbackQuery() != null) {
+            update.getCallbackQuery().getMessage().getChatId();
+        }
+
+        throw new IllegalStateException("Can't extract chatId from 'Update'");
+    }
+
+}

stbf-test/src/main/java/ru/penkrat/stbf/test/BotRequestImpl.java

@@ -6,6 +6,7 @@ import java.util.Random;
 import lombok.Builder;
 import lombok.Getter;
 import ru.penkrat.stbf.api.BotRequest;
+import ru.penkrat.stbf.api.BotSession;
 
 @Builder
 class BotRequestImpl implements BotRequest {
@@ -14,6 +15,7 @@ class BotRequestImpl implements BotRequest {
 	private String phoneNumber;
 	private String callbackData;
 	private String callbackMessageText;
+	private BotSession session;
 
 	@Getter
 	@Builder.Default
@@ -39,4 +41,9 @@ class BotRequestImpl implements BotRequest {
 		return Optional.ofNullable(callbackMessageText);
 	}
 
+	@Override
+	public BotSession getSession() {
+		return session;
+	}
+
 }